Back to back source - Githubissues

OpenGATE / opengate

Gate 10 (beta)

http://www.opengatecollaboration.org

GNU Lesser General Public License v3.0

41 stars 37 forks source link

Back to back source #385

Closed dsarrut closed 3 months ago

dsarrut commented 3 months ago

Based on #381. @MaxTousss : I duplicate and consolidate this PR to make it standalone. If you agree, it can be merged in the master while you can still continue your branch (#381)

MaxTousss commented 3 months ago

@dsarrut : I must admit I am confused on the goal of this PR. #381 was started from #367 so I could push my updates (I can't contribute to a PR made by someone else, right?). In my eye, #381 was already a standalone and #367 was redundant. Is there something I am missing?

Also, I would not merge this branch as is since it still has artifacts from my debugging (e.g., two last line of test072) and I am still unsure of how I am testing back-to-back, which is why I asked for "a link to a comprehensive description of particle's attributes".

I imagine there is a reason why you want it merged to main now. Thus, I leave that decision to you.

dsarrut commented 3 months ago

sorry for the confusion ;)

I think a simple "back to back" source is interesting for some users, without waiting for acoli stuff
I started this new PR to merge it independently while still allowing you to continue #381 at your pace

Maybe I overlooked it, I thought test072 was really testing something, this is not the case?

The list of attributes is not really comprehensively described, there is only a rough documentation here : https://opengate-python.readthedocs.io/en/latest/user_guide.html#digitizerhitscollectionactor Position, Direction refer to the step. Pre/Post refer to pre step and post step (see geant4 doc). When "Event" is prepended, it refers to the Event (primary particle) instead of the step.

hope that helps!

MaxTousss commented 3 months ago

That explains the "merge now"!

As for the "really testing something", yes it does but:

It was "broken" for debug before e8dfcef commit. Now that you modified that, it should behave as intended.
The tests were made with my limited knowledge of attributes and brute-force, as shown by the hacky way I uses to find true back-to-back (b2b_dir). If you don't mind that, then yes, it is testing things. However, I do not claim that the tests are sufficient. For example, I still doesn't understand why e+ and e- particles seems to be born from gamma photons interacting with the air/void...

dsarrut commented 3 months ago

OK, so I merge. You can continue #381 to bring a little bit of accolinearity to those boring perfectly back to back gammas ;)