search

OpenGATE / opengate

Gate 10 (beta)
http://www.opengatecollaboration.org
GNU Lesser General Public License v3.0
43 stars 38 forks source link

Use qt6 for mac instead qt5 #442

Closed tbaudier closed 8 hours ago

BishopWolf commented 2 weeks ago

You shall move completely to QT6 in all systems. QT5 is mostly in maintenance status and will die eventually. Moreover, QT6 solves a lot of issues, specifically for PyQt.

nkrah commented 2 weeks ago

As a side note: I have been experiencing compile issues on my Mac with Qt5 (installed via brew) and geant4 recently. Ended up compiling geant4 without Qt for now. In any case a good idea to move to Qt6

BishopWolf commented 2 weeks ago

Linked issue https://github.com/OpenGATE/opengate/issues/338

BishopWolf commented 1 week ago

"[Remove macos14 because python does not work now]"

This is because python 3.8 doesn't work on mac14, you shall drop python 3.8 support for that. Most systems (including debian 11 Bullseye) are on minimum python 3.9 anyway.

BishopWolf commented 1 week ago

This error is not related to python. There is a missing key in the dictionary pulled from C++.

There is also this error that I think is more relavant

WARNING: Requirement 'dist/opengate_core-*-cp310-cp310-manylinux*_x86_64.whl' looks like a filename, but the file does not exist
ERROR: Invalid requirement: 'opengate-core==*': Expected end or semicolon (after name and no valid version specifier)
    opengate-core==*
tbaudier commented 1 week ago

"[Remove macos14 because python does not work now]"

This is because python 3.8 doesn't work on mac14, you shall drop python 3.8 support for that. Most systems (including debian 11 Bullseye) are on minimum python 3.9 anyway.

Here, the error was due to that problem: https://github.com/actions/setup-python/issues/825 BTW, 3.8 will be drop

BishopWolf commented 1 week ago

Beware of this warning (it should be an error):

/Users/runner/miniconda3/envs/opengate_core/lib/python3.10/site-packages/setuptools/command/build_py.py:215: _Warning: Package 'opengate_core.plugins' is absent from the `packages` configuration.
tbaudier commented 1 week ago

Beware of this warning (it should be an error):

/Users/runner/miniconda3/envs/opengate_core/lib/python3.10/site-packages/setuptools/command/build_py.py:215: _Warning: Package 'opengate_core.plugins' is absent from the `packages` configuration.

'opengate_core.plugins' contains the qt librairies needed by QtCore to display. You can find libqcocoa for exemple. No python scripts are available in that folder so I'm not sure the folder should be in the packages configuration.

I need to create that folder because delocate could not find theses librairies by itself

BishopWolf commented 4 days ago

I see you are testing brew instead of conda, just a hint: you can't have mixed packages with BOTH installers. Therefore, to use brew you must drop conda completely (for all packages) watch this line https://github.com/OpenGATE/opengate/blob/20b44ad0c91b617a7b61dee132b3076f0c29cfe3/.github/workflows/main.yml#L107

tbaudier commented 8 hours ago

I see you are testing brew instead of conda, just a hint: you can't have mixed packages with BOTH installers. Therefore, to use brew you must drop conda completely (for all packages) watch this line

https://github.com/OpenGATE/opengate/blob/20b44ad0c91b617a7b61dee132b3076f0c29cfe3/.github/workflows/main.yml#L107

conda is just used to install qt6 c++ librairies. I do not use conda to install python packages. For macOS, I use Github Actions for intel Mac and Cirrus for M1. On M1 brew do not succeed to install qt6 correctly, this is why I used conda.