search

OpenGATE / opengate

Gate 10
http://www.opengatecollaboration.org
GNU Lesser General Public License v3.0
53 stars 46 forks source link

UC Davis OptiGAN Bug Fix #574

Open guneet19 opened 1 week ago

guneet19 commented 1 week ago

Changed OpitGAN code to reflect steps_to_store = "first".

steps_to_store = "entering" leads to incorrect output from OptiGAN. Even filtering the root output gives wrong results.

@nkrah Is it possible to default to steps_to_store = "first" when using OptiGAN?

nkrah commented 1 week ago

Good idea to add the possibility to override the default values coming from the base class. I'll implement that.

guneet19 commented 6 days ago

@nkrah If you haven't started working on this already. We have a member in our team who can start working on it. He is getting trained on Gate 10 and can be a good starting point for contribution. For now, I will add a doc stating to use steps_to_store = "first" when using OptiGAN. In that case, this code can be merged if there are no conflicts.

nkrah commented 5 days ago

@guneet19 : It's on my list, but I have not started yet. Pushing the user guide forward is the priority right now.

If you can add a line in the doc, as you suggest, that would be good.

Otherwise, thanks for the offer. Handling the user infos is actually quite deep down in the class factory mechanics used for GateObjects. I don't think that is a good starting point for somebody being trained on GATE 10.