OpenGIS / Waymark

Waymark adds powerful mapping features to WordPress that are easy to use. Create beautiful, interactive Maps that you can customise to suit your needs.
https://www.waymark.dev
GNU General Public License v2.0
20 stars 6 forks source link

Incorrect download content #3

Closed shenki closed 2 years ago

shenki commented 2 years ago

Hello! I am using your plugin for a running community website and it's great.

We've got a setup where we have three different maps on the one page, and they display fine. However, when using the GPX download function the file contains the incorrect content. You can see here:

https://trailrunningsa.com/mt-misery-2021/#Short

Details -> Download

Is this a bug in the plugin, or are we using it incorrectly?

morehawes commented 2 years ago

Hi @shenki,

Thanks for reaching out. I'm glad you like the plugin, this kind of use-case was exactly what I had in mind when creating Waymark :) I have lots more features to come!

I can see this on your site too: when downloading using the Shortcode Header each file contains the "Long" Map data. So this does appear to be a bug.

I am a little pressed for time at the moment, but I will be sure to spend some time on this in the next week or two. I will let you know if I have trouble replicating this on my end.

When Exporting from the Map Details page (i.e. clicking "Details" > "More Details") things appear to be working correctly. As a temporary work-around you could hide the Export option from the Shortcode with this CSS:

.waymark-shortcode .waymark-header .waymark-meta-export_data { display: none; }

Thanks again,

Joe

morehawes commented 2 years ago

Hi @shenki,

I have created a fix for this, available in this branch. Please feel free to download this version and let me know if the Export feature is now working as expected.

Please note you may need to clear your browser cache (of Waymark JavaScript) to see the change.

Cheers,

Joe

morehawes commented 2 years ago

This fix is included in the latest release. Marking as closed, thanks again for bringing this to my attention.

Joe

shenki commented 2 years ago

Thanks for your help @morehawes

I've updated to the new version and it's working as we would expect.