Closed bystrzan closed 12 months ago
I tested it and it works soooo good. I'l try to make pr till next week.
Hi @bystrzan,
Thanks for reaching out. I definitely agree that there is room for improvement on this front.
Currently Leaflet.Sleep delays the zooming of the Map while scrolling, which isn't perfect, but is a big improvement over the default behaviour.
I think ideally a Setting should be added to let the user decide what approach is best for their application - a timed delay, or another approach like the one you linked to.
I am hesitant to add extra bloat to the plugin for all users, but as the plugin grows I do want accommodate as many users as possible.
I have future plans for improving how the plugin loads assets, including the ability for users to integrate Leaflet plugins with Waymark themselves. A big change, but it's on the list!
Cheers,
Joe
Hey Joe, great plugin. My sincere compliments.Works great! I will contribute into italian and russian traslation for sure. Since im also getting into webdev i was thinking why your plugin is not listed on official leaflet.js.
Long story short. This requested 2 finger thing is really comfortable on mobile devices. Please when you got time i think its really valuable option.
From me two essential things: toggle off header and possibility to wrap around div class for animation. (Aos for example) I know, i have already disabled header and made a fast js script that actually works well, but imho this feature should be included ( for perfect personal fit atm). Happy new year and wait for my translations.
Cheers.
Hi @phrizm,
Thanks for your kind words and feedback. I do plan on adding zoom options to the next release and will definitely look into Leaflet.GestureHandling. Though at this point I am still reluctant to include an additional plugin.
toggle off header and possibility to wrap around div class for animation.
Thanks for these suggestions, though I do not follow you. Could you add further details as a separate issue?
Cheers, Joe
Hello Joe. Ok i will open few issues and few things that i found. Im going to make em as separate issues so you can keep track.
Thank you.
Interaction options (Settings > Map > Interaction) were added to v0.9.28, with the intent on improving this.
Cheers,
Joe
It's known problem that Leaflet maps zooms when user scrolls. There's a nice solution to reslove it like Google made it with their maps. Please check: Leaflet.GestureHandling