search

OpenGamePanel / OGP-Website

GNU General Public License v2.0
127 stars 104 forks source link

Update #584

Closed Bebiano86 closed 2 years ago

Bebiano86 commented 2 years ago

new datePickerInput check method

Zorrototo commented 2 years ago

Can you give more info about why you created this PR?

Bebiano86 commented 2 years ago

check never works as intended because the object "always exists", only with a length equal to its structure in this case 0 (because there is no hence the .length which confirms whether the object is greater than 0

info: https://www.opengamepanel.org/forum/viewthread.php?thread_id=7898&rowstart=100&showlast=true#post_41008

Zorrototo commented 2 years ago

Is the issue happening only with this theme or is it a global issue wit hall themes? From my understanding it is a global issue but this is only with this theme that it seems to have happened (can't try right now).

Bebiano86 commented 2 years ago

it is a global problem the error is present in all themes.

oNdsen commented 2 years ago

@Bebiano86 You check for boolean (datePickerInput.length). Please check if the Value is greather than 0 otherwise it will not work. Check my example: https://github.com/oNdsen/OGP-Website/commit/bcaa19b518944a855ea152fe6144bac981c83ffd @Zorrototo Yes it is a global Problem.

Bebiano86 commented 2 years ago

@oNdsen done

own3mall commented 2 years ago

@oNdsen, this is not true. Just checking for .length should be sufficient. However, both work.

oNdsen commented 2 years ago

Interessting, didnt worked with boolean check on my side. But maybe i just was too quick ;) Thanks for Check!

own3mall commented 2 years ago

Fixed in https://github.com/OpenGamePanel/OGP-Website/pull/585

Thanks