search

OpenGamma / ElSql

Manage external SQL files in Java with a little DSL goodness
Other
101 stars 26 forks source link

@PAGING tag does not allow literal values #19

Closed evpaassen closed 9 years ago

evpaassen commented 9 years ago

The @PAGING tag currently does not allow literal values to be passed in. While this behaviour is correct according to the documentation (@PAGING(offsetVariable,fetchVariable)), allowing so could be useful in some cases.

For example when I always want to fetch the top x results, I'll have to add an hardcoded offsetVariable = 0 param next to the variable fetchVariable = x param.

I could try to create a PR for this, if desired.

jodastephen commented 9 years ago

We do like PRs ;-)

evpaassen commented 9 years ago

OK, I'll give it a try in the next few days.