search

OpenGen / GenSQL.query

42 stars 5 forks source link

Support `GENERATE * EXCEPT` functionality #99

Closed KingMob closed 6 months ago

KingMob commented 7 months ago

This looks fine though I am NOT the ideal reviewer for bnf grammar changes... is there some test you might add that checks the new behavior of the matcher?

Otherwise :shipit:

@sritchie The grammar matching should be tested by the strict/permissive parser_test files. Was there another test you wanted to see?

sritchie commented 7 months ago

@KingMob looks great, no extra tests needed if those branches are covered!

KingMob commented 6 months ago

@sritchie How do we examine code coverage results? I'm not experienced with these tools.

I clicked thru the coverage check in GH Actions, found a line in the logs saying the report was uploaded, and to go here, but it said the reports are unusable.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.60%. Comparing base (95352b2) to head (013d3ed).

Files Patch % Lines
src/inferenceql/query/plan.cljc 69.56% 3 Missing and 4 partials :warning:
src/inferenceql/query/literal.cljc 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #99 +/- ## ========================================== - Coverage 75.87% 75.60% -0.28% ========================================== Files 30 30 Lines 1484 1496 +12 Branches 60 64 +4 ========================================== + Hits 1126 1131 +5 - Misses 298 301 +3 - Partials 60 64 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.