search

OpenGenus / cosmos

World's largest Contributor driven code dataset | Used in Quark Search Engine, @OpenGenus IQ, OpenGenus Visual Project
http://internship.opengenus.org
GNU General Public License v3.0
13.58k stars 3.69k forks source link

Binary Tree related category issues. #1138

Open hwchiu opened 7 years ago

hwchiu commented 7 years ago

There's a category binary_search_tree_height in code/data_structures/Tree now. That's weird for me because I think there's no different between binary_search_tree_height and binary_tree_height. I think maybe we can rename binary_search_tree_height to binary_tree_height to make it more general.

Besides, do we need to rename the directory Tree to tree for consistency style ?

AdiChat commented 7 years ago

Yes, the above two categories can be merged 👍 The directory tree exists in lower case 👍

hwchiu commented 7 years ago

Thanks, there're some problem in my environment so I still see some upper case directory name, such as Stack/Tree. lol. So, Should I rename binary_search_tree_height to binary_tree_height or binary_tree_maximum_height since there's a binary_tree_minimum_height category.

AdiChat commented 7 years ago

binary_tree_maximum_height should be consistent 👍

There were multiple directories with both upper and lower case. I merged them yesterday. The problem was that windows is case-insensitive and git seems to be case-sensative 👍