OpenGenus / memes

MIT License
15 stars 15 forks source link

Making changes in files to suport for mac or linux os #121

Closed ulshell closed 5 years ago

AdiChat commented 5 years ago

Looks great 😍

Hope you are enjoying your journey 🚆 with OpenGenus positive_opengenus

srivkrnt commented 5 years ago

@ulshell can you share the output of openmemes --test=1. So that we can decide and assign it to someone else who can test this on windows and fix this.

ulshell commented 5 years ago

Yes it is causing an error. I am creating an issue to it if anyone will want could correct just small change needed of platform may be it due to python 2 or 3. ![Uploading Screen Shot 2019-03-18 at 1.00.55 PM.png…]()

ulshell commented 5 years ago

@srivkrnt that's why I have made two folders for different users in #112 pull request which I closed. So that there will not be any problem for both users and even softwares also release in different platform versions. May be that could help.

srivkrnt commented 5 years ago

@ulshell Your previous solution that involved platform detection could work fine without having two files.

I am claiming issue #125

srivkrnt commented 5 years ago

I have fixed it with #126