search

OpenGenus / memes

MIT License
15 stars 15 forks source link

Updated checkarg function #128

Closed vaibhav721 closed 4 years ago

ulshell commented 5 years ago

@vaibhav721 Kindly re-fork the repository and do changes again to get rid of conflicts.

vaibhav721 commented 5 years ago

On which pull request I have to make changes?

On Mon, Apr 8, 2019 at 6:50 PM Vikrant Srivastava notifications@github.com wrote:

@srivkrnt requested changes on this pull request.

Please resolve the conflicts.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenGenus/memes/pull/128#pullrequestreview-223837771, or mute the thread https://github.com/notifications/unsubscribe-auth/Ai_0PbRS0gkj6XeggTzpsiazJiEeMMMRks5ve0IngaJpZM4b_9on .

ulshell commented 5 years ago

https://github.com/OpenGenus/memes/pull/128#issuecomment-476738592 see comment

srivkrnt commented 5 years ago

@vaibhav721 as @ulshell suggested . Fork the repository again because as I see your branch is 73 commits behind OpenGenus/master. Re Forking would be a good idea to avoid unnecessary problems. Either way first update your branch with any way you wish and make the changes again for the checkarg() function and then I would be able to review the changes and move forward with the pull.

ulshell commented 5 years ago

Kindly see this pull request @srivkrnt this need to be corrected or else close it