search

OpenGenus / vidsum

Generate summary of any video :tv: anywhere and anytime
GNU General Public License v3.0
262 stars 69 forks source link

Updated CONTRIBUTORS.md/CONTRIBUTING.md files #33

Closed JamesMCo closed 7 years ago

JamesMCo commented 7 years ago
TurnrDev commented 7 years ago

Seems when my pull request got merged it duplicated CONTRIBERS.md/CONTRIBUTING.md

I think it's time to merge these two again... The real question is... why was it moved to .github/

AdiChat commented 7 years ago

The commit_template.md must be named as contributing.md

bhaveshAn commented 7 years ago

The real question is... why was it moved to .github/

It is done because when the PR is merged containing the template. For subsequent issues, and PR it looks in the .github dir and same template is available for every new issue and PR.

for templates like ISSUE_TEMPALTE.md and CONTRIBUTING.md , both should be in .github/

TurnrDev commented 7 years ago

Ah! Also read somewhere after commenting that the wiki is simply .md files in .github Edit: Wherever I read that was wrong. I'm dropping out of this discussion.

However, the wiki does need updating.

AdiChat commented 7 years ago

Looks good 👍

Hope you are enjoying your journey with OpenGenus

JamesMCo commented 7 years ago

I've just realised that I accidentally provided the incorrect url for Bhavesh Anand (I used Vipul's profile instead). Will submit a fix :+1:

bhaveshAn commented 7 years ago

@JamesMCo please do. Thanks !

lwgray commented 7 years ago

I think it is common practice to include commit/issue template in .github or docs folder. see github doc

bhaveshAn commented 7 years ago

Yeah

On Oct 6, 2017 2:19 AM, "Larry Gray" notifications@github.com wrote:

I think it is common practice to include commit/issue template in .github or docs folder. see github doc https://help.github.com/articles/creating-an-issue-template-for-your-repository/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenGenus/vidsum/pull/33#issuecomment-334587823, or mute the thread https://github.com/notifications/unsubscribe-auth/AV37-myrMz7ZMIB07wY3GAKhr3Y7T9gqks5spUDbgaJpZM4Pt3CJ .