search

OpenGenus / vidsum

Generate summary of any video :tv: anywhere and anytime
GNU General Public License v3.0
262 stars 69 forks source link

fix : Get summary using a child process if a URL is provided #41

Closed ilimugur closed 7 years ago

ilimugur commented 7 years ago

moviepy does not close files until garbage collection is done. The fix calls a function using moviepy through a child process, so that the usage of the relevant resources stops as soon as the function is done, and said resources can be manipulated by the parent process.

Fixes issue #38.

ilimugur commented 7 years ago

I thought of running all calls to get_summary using a child process for a more elegant design, but I ended up not doing it. The child process idea is an immediate fix, as @AdiChat put it, and the design of this project should not be affected by a defect in moviepy, which will likely get fixed at some point. Consequently, I directed the call to get_summary to a child process only when it made a difference.

AdiChat commented 7 years ago

Looks good 👍 Kindly add yourself to our Contributors list in a pull request 😄 Hope you are enjoying your journey with OpenGenus

lwgray commented 7 years ago

@ilimugur Great job!