search

OpenGeoMetadata / GeoCombine

A Ruby toolkit for managing geospatial metadata
https://github.com/OpenGeoMetadata/GeoCombine
Other
20 stars 23 forks source link

Bug: Explicit require net/http #158

Closed mnyrop closed 11 months ago

mnyrop commented 11 months ago

Hi folks!

We're working on a small CLI gem for our in-house GBL that uses GeoCombine. We hit a small bug with GeoCombine::Harvester. calling .repositories throws:

NameError:
       uninitialized constant GeoCombine::Harvester::Net

from this line https://github.com/OpenGeoMetadata/GeoCombine/blob/2d59072b8e0221b258f78353f8299a625e8889c5/lib/geo_combine/harvester.rb#L104

Adding an explicit require 'net/http' to harvester.rb solved it; this PR includes that & a small second commit to make rubocop test pass (edit: looks redundant with #157?)

Spec tests passed locally on ruby-3.2.2.

thatbudakguy commented 11 months ago

not sure why CI isn't running, but I'm going to go ahead and merge this. thanks!

mnyrop commented 11 months ago

@thatbudakguy it looks the CI only runs on commits & not PRs! https://github.com/OpenGeoMetadata/GeoCombine/blob/55add25b05b57bfc37940bf2d9f46f90872e0fa0/.github/workflows/ruby.yml#L3

thatbudakguy commented 11 months ago

oh, good catch! I should fix that.