Zooming causes layers that are toggled off to reappear.

[cjh1]

Here are the step to recreate:

• Add layer.
• Toggle it off.
• Zoom

[cjh1]

After a little investigating I can see what the issue is here. Basically and zoom or resize events end up causing updateAndDraw(...) to be called on the map which in term causes update(...) to be called on the featureLayer. The featureLayer requests the data from data source and rebuilds its features. This new set of features doesn't respect the visibility of the layer. So issue can be resolved by setting the correct visibility on these new features. However I think there is remove optimization here:

• Why does update need to called on a resize or zoom event? The data will not have changed?
• If a featureLayers visibility is set to false shouldn't we just expire all the features rather than setting the visibility to false?

[cjh1]

It looks like the legend has the same issue, the issue can be solved in the same way. However, the questions about optimization apply equally.

[cjh1]

Changes pushed in 200-fix-toggle-visibility

[cjh1]

Thats a geojs branch

[cjh1]

@aashish24 can you take a look at this branch

[aashish24]

Yes, I should have some time this afternoon. thanks

[aashish24]

Approved