search

OpenGeoscience / geoweb

Open source geoscience tools and applications
8 stars 3 forks source link

Allow ClimatePipes credentials to be used with ESGF #99

Closed cjh1 closed 10 years ago

cjh1 commented 11 years ago

When we have implemented user authentication, it would be nice to allow these credentials to be used with ESGF. This might be possible if we base our authentication on OpenID.

cjh1 commented 10 years ago

I have authentication working login to site and logging out. Ran into some trouble with cache pages. I now need to make sure the ESGF download can use the certificate that is created when users login.

aashish24 commented 10 years ago

Expecting to get done by end of the week.

cjh1 commented 10 years ago

Have push 99-esgf-session-authentication, need to run JSLint on it.

aashish24 commented 10 years ago

Cool..will review today / tomorrow.

aashish24 commented 10 years ago

@cjh1

Sorry , I had to reformat my system and that's why the delay.

I reviewed the geojs branch and approved it. Its in master now. Could you please update the geoweb branch and make sure you refer only the commits in master of geojs?

Thanks,

cjh1 commented 10 years ago

Done, pushed branch which points to geojs master.

aashish24 commented 10 years ago

Pushed a minor fix on the same branch. Could you please have a look? Also you want to merge your branch to the next at the point of review -:)

The changes looks good to me.

cjh1 commented 10 years ago

Looks good to me

aashish24 commented 10 years ago

Merged!