Closed annehaley closed 1 year ago
@annehaley I'd like to address the last 2 items of that checklist in a follow-up PR. The current change is pretty well scoped, and those last two items could involve a decently large change themselves.
@annehaley I'd like to address the last 2 items of that checklist in a follow-up PR. The current change is pretty well scoped, and those last two items could involve a decently large change themselves.
Makes sense. I can review this PR as-is later today.
I tried out the zoom to region feature a lot, and it works fine for most regions. The only one I found that did not work as expected was the Jamaica Plain region. This is what it zoomed to:
It seems that both of those polygons are a part of the same region. See below where I clicked on the "main" part of it. You'll notice that in both your screenshot and in mine, the map zooms to fit both regions.
Both areas are connected by a thin strip that runs along the boundary for "Longwood". I tried to verify that this is the correct boundary and wasn't a data ingress error by loading the Jamaica Plain feature into a separate online viewer, but it doesn't render it for some reason. The screenshot below shows that thin connecting piece
Oh ok, thanks for clarifying! It seems to be working properly then! I had clicked on the tiny portion and thought that was the whole Region. Perhaps this is a good reason to go back to trying to color them uniquely... But that can be saved for later.
For @AlmightyYakob to take over. The below items are my current understanding of the task, but this may be further refined.