search

OpenGreekAndLatin / First1KGreek

XML files for the works in the First Thousand Years of Greek Project. Please see our Wiki on how to contribute.
https://opengreekandlatin.github.io/First1KGreek/
Creative Commons Attribution Share Alike 4.0 International
91 stars 85 forks source link

(tlg4016)_002_004 #2715

Closed AlisonBabeu closed 1 year ago

AlisonBabeu commented 1 year ago

Updated errors per issue #2714.

@lcerrato can't find an issue in terms of a naming error for tlg4016.tlg003.1st1K-grc1.xml but fixed the other two errors.

lcerrato commented 1 year ago

@AlisonBabeu The metadata is bad and the other errors are still here.

lcerrato commented 1 year ago

@AlisonBabeu As this is a separate PR from the current one, you are going to have to pull these changes into the open PR(s) in order to fix the error once we get this passing.

AlisonBabeu commented 1 year ago

ok @lcerrato now I must admit I'm seriously confused. When I looked at the other pull request and branch, the tlg4016 files showed up as having no changes at all. Also, when I'm looking at the files I changed, I thought I had corrected the errors you mentioned. In the files I changed:

tlg4016.tlg002.1st1K-grc1.xml had the edition div type changed from grc2 to grc1 and for tlg4016.tlg004 I fixed the URN name in the cts_.xml file to agree with the renamed file.

Also, my metadata is often bad, but this time I'm not sure what you mean? Sorry maybe I have a case of the Fridays.

lcerrato commented 1 year ago

@AlisonBabeu There was a space in the cts file I changed above. I will check the run when I get through the webmaster issue. There will be no changes in the other PR because these changes have not been integrated into that branch as yet.