Open gregorycrane opened 1 year ago
hi @gregorycrane so I looked over these two files there. Just two comments on the English file at this point fromme:
1.) You have the titles mixed up in that you have the title of the volume in the header at line 7 (<title xml:lang="eng">The Works of Philo Judaeus</title>)
, where you should have the title of the individual work.
This should be in the structured bibl section, where you have <title xml:lang="eng">On the Creation of the World</title>
, so you just need to reverse those.
2) You should update the file name from <idno type="filename">philo_1_1854.xml</idno>
Two comments for the Greek file: 1) For the long haul we are updating all of the opp URNs for the Greek files to 1st1K, that way we don't have conflict with metadata in the catalog, but that is something I can do at the end when I add updated catalog metadata for all the translations.
2) We have also started standardizing the metadata in the
Further work needed:
@gregorycrane Release date is the date the public sees the work, not the creation date(s) which would be recorded in the change log.
I am building a pull request for the Yonge English translations of Philo (new addition). A separate one for the Berlin Greek updated files will follow.
I have gone back over comments from May (https://github.com/OpenGreekAndLatin/First1KGreek/pull/2726) and also for Lucian (https://github.com/PerseusDL/canonical-greekLit/pull/1470). I may have missed something.
Questions
Things I have not changed
Things I have changed
\Digital conversion and editing\
from a recent file (tlg0550)