search

OpenGreekAndLatin / First1KGreek

XML files for the works in the First Thousand Years of Greek Project. Please see our Wiki on how to contribute.
https://opengreekandlatin.github.io/First1KGreek/
Creative Commons Attribution Share Alike 4.0 International
91 stars 85 forks source link

(tlg0018-cohn2) updates to the Cohn/Wendland Greek of Philo #2758

Closed gregorycrane closed 1 year ago

gregorycrane commented 1 year ago

explanations are here: https://github.com/OpenGreekAndLatin/First1KGreek/issues/2754

gregorycrane commented 1 year ago

By popular demand, < and > entities have been removed and replaced with \ tags -- it took some time because there were missing angle brackets and these popped up with unbalanced \ tags. But it is done.

gregorycrane commented 1 year ago

Oh- and I put back the \ statements such as:

Original text was generated with OCR in 2013 and many errors had crept in. GRC, through manual and automated methods, made more than 123 corrections. Markup was also refined and changed throughout.
gregorycrane commented 1 year ago

I don't see where the cts Greek edition labels don't have xml:lang="grc"

I also don't understand what this means: "HathiTrust links include specific view modifications"

lcerrato commented 1 year ago

My comment was on the titles used (the <ti:label>, not the language attribute. (Sorry, too many overlapping threads). Greek works typically have Greek titles. Plutarch example here: https://github.com/PerseusDL/tei-conversion-tools/wiki/cts-textgroup-and-work-metadata-files

Sometimes the links to the pdfs have things like a zoom or other modifications in them. This is not the best example. https://babel.hathitrust.org/cgi/pt?id=hvd.32044054757893;view=1up;seq=187 vs https://babel.hathitrust.org/cgi/pt?id=hvd.32044054757893&seq=187

Both issues can be handled after ingest.

gregorycrane commented 1 year ago

Do you need to approve the PR ? Merging is still blocked.

lcerrato commented 1 year ago

I haven’t reviewed your changes, was working on English