OpenGrok / docker

WARNING: this repository is archived !
58 stars 31 forks source link

Opengrok/docker opengrok 1.0.0 #1

Closed devnagui closed 7 years ago

devnagui commented 7 years ago

Small contribution to your project guys, hope that you like it.

Changes:

Feel free to change whatever you dislike.

devnagui commented 7 years ago

Ahhh! Almost forgot, you should change the .md file with the opengrok official account from docker.hub!

tarzanek commented 7 years ago

lovely! thank you Nathan!

Can you please either follow (if you plan other open source contributions to Oracle): http://www.oracle.com/technetwork/community/oca-486395.html or just read it and say/write here "I accept OCA for this patch" ?

tarzanek commented 7 years ago

fyi, other tested version is here: https://github.com/nerakhon/docker-opengrok I will try to review , @nerakhon if you have a spare cycle, could you have a look too, please? ;) obviously, the best would be to merge the versions taking the best out of both

devnagui commented 7 years ago

Hi @tarzanek,

I accept OCA for this patch.

I was looking the other patch that you pointed, the release used is "0.13-rc" and the original publisher is "itszero", you might have to check with him.

There is also too much bash scripts action going out of the docker file, not a expert here but it seems "strange".

His ".md" in the seems more descriptive, I like the style. I/We could adapt mine in case you like it.

tarzanek commented 7 years ago

ok, I will merge now and we can start adapting the code/merging

tarzanek commented 7 years ago

thank you @devnagui !