OpenGrok / docker

WARNING: this repository is archived !
58 stars 31 forks source link

deploy to server root. fixes #8 #9

Closed splitbrain closed 6 years ago

splitbrain commented 6 years ago

This deploys OpenGrok as the default web app in tomcat. All tomcat default apps, docs and examples have been removed from the webapps dir. A redirect from /source has been added for backward compatibility.

tarzanek commented 6 years ago

so if you're ok and the changes work, then let's go and merge this ...

tarzanek commented 6 years ago

the main deal with OpenGrok deploy are the fixes done to webapp if you have custom data roots or paths to config files, but that is given and set to default in docker, so people won't really need to change this (yet, and if they will, they will just have to fix deploy .... )

splitbrain commented 6 years ago

Anything that needs to be done here to get this merged or is this good to go?

tarzanek commented 6 years ago

let's do it ... the only thing that needs to be done is more like administration in OpenGrok and eventually getting rid of the WEBAPP variable ...

tarzanek commented 6 years ago

thank you @splitbrain , let's have a look then on WEBAPP variable and let's make it obsolete if all works as you say ...

splitbrain commented 6 years ago

Thanks for merging. Can you push it to docker hub please?

tarzanek commented 6 years ago

I'd hope docker hub will pick it up automatically, shouldn't it ?

tarzanek commented 6 years ago

it did:

Status Actions Tag Created Last Updated Success latest 2 days ago 2 days ago

so I'd hope it works (didn't test it yet)

splitbrain commented 6 years ago

https://hub.docker.com/r/nagui/opengrok/builds/ was last built 8 months ago. I guess I'm looking at the wrong repo? Which one is this deployed to? I guess the README needs an update?

tarzanek commented 6 years ago

https://hub.docker.com/r/opengrok/docker/ is the one I tied to the repo ...

so yes, README might be obsolete, sorry for that, do you mind fixing it?

tarzanek commented 6 years ago

I didn't most probably change it, since I didn't finish my tests :( So if the opengrok/docker repo works for you, then the README should definitely be changed ...