OpenHFT / Chronicle-Map

Replicate your Key Value Store across your network, with consistency, persistance and performance.
http://chronicle.software/products/chronicle-map/
Apache License 2.0
2.74k stars 468 forks source link

Resource cleanup #485

Closed JerryShea closed 1 year ago

JerryShea commented 1 year ago

ensure ChronicleHashResources always calls releaseEverything inside of a synchronized block

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

nicktindall commented 1 year ago

I vote we don't do this unless there's a good reason to do it, or that we've properly understood the implications. We could be introducing a deadlock. Also seems to be undoing 73ae264124ce55057f8574d4dfba0d9dcdc6af6d. @alamar to have the final say.