search

OpenHFT / Chronicle-Map

Replicate your Key Value Store across your network, with consistency, persistance and performance.
http://chronicle.software/products/chronicle-map/
Apache License 2.0
2.77k stars 469 forks source link

Use file store from file instead from file system #519

Closed Sax388 closed 7 months ago

Sax388 commented 7 months ago

Resolves #518

I tested it with the current Java 21 (eclipse-temurin)

[WARNING] Tests run: 1291, Failures: 0, Errors: 0, Skipped: 73
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  07:06 min
[INFO] Finished at: 2024-02-22T21:37:48+01:00
[INFO] ------------------------------------------------------------------------
JerryShea commented 7 months ago

Thanks @Sax388 let us review.

For us to be able to merge this we will need you to sign the CLA please.

JerryShea commented 7 months ago

@peter-lawrey @nicktindall - I have confirmed mvn install passes on on of the dev servers

Sax388 commented 7 months ago

Thanks @Sax388 let us review.

For us to be able to merge this we will need you to sign the CLA please.

That's done ✅. Thank you for the review, I appreaciate it.

WeatherGod commented 6 months ago

This might actually fix my issue #530. If you can give me guidance on how to build the patched jar file, I can test it out on my system.

Sax388 commented 6 months ago

This might actually fix my issue #530. If you can give me guidance on how to build the patched jar file, I can test it out on my system.

You don't need to build it yourself, these changes are included in the most current version: https://mvnrepository.com/artifact/net.openhft/chronicle-map/3.25ea6

PS For building the patched jar I had to enable the maven central repository in the build file and disable the private repositories.

WeatherGod commented 6 months ago

Thanks, that helped, but seems like it wasn't the complete solution to the build problem. Since I'm just trying to verify the fix for a tiny piece of another project that I was using, I needed to build the 3.23.5 jar, but it seems that it's POM file points to a different chronicle-bom (2.23.123) than what the other project explicitly set in its POM (2.23.136). With chronicle-map's checkout of v3.23.5 code, I changed its POM to point to chronicle-bom:2.23.136, and it was able to build! I applied this change and am running the tests now to see how it goes.

WeatherGod commented 6 months ago

Confirmed! This fix solved the problem of using Chronicle-Map on a file in a k8s ephemeral volume! Thank you.