search

OpenHFT / Chronicle-Salt

Chronicle wrapper for the NaCl library
Apache License 2.0
30 stars 18 forks source link

Test verify #2

Closed motoras closed 6 years ago

motoras commented 6 years ago

More testing and cleanup.

peter-lawrey commented 6 years ago

Can you use spaces instead of tabs as it creates lots of changes when there doesn't need to be? I use the default Java formatting for IntelliJ. Can you update your fork and issue the pull request again?

motoras commented 6 years ago

Sorry, I can't believe I had my editor configured to use tabs. I'll fix that.

I am also going to add a formatting goal in maven so when you build, it will format the files, so github sources will always have the same formatting profile.

I'll reissue the pull request later today.

On Thu, Jan 25, 2018 at 11:36 AM, Peter Lawrey notifications@github.com wrote:

Can you use spaces instead of tabs as it creates lots of changes when there doesn't need to be? I just the the default Java formatting for IntelliJ. Can you update your fork and issue the pull request again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenHFT/Chronicle-Salt/pull/2#issuecomment-360412490, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEemg2sW-TIPozKvFHiukgF0L54BguBks5tOEs6gaJpZM4Rq4EF .

peter-lawrey commented 6 years ago

Can you use the same formatting as the default for IntelliJ which I believe follows the old Sun recommended standard.

On 25 January 2018 at 10:29, motoras notifications@github.com wrote:

Sorry, I can't believe I had my editor configured to use tabs. I'll fix that.

I am also going to add a formatting goal in maven so when you build, it will format the files, so github sources will always have the same formatting profile.

I'll reissue the pull request later today.

On Thu, Jan 25, 2018 at 11:36 AM, Peter Lawrey notifications@github.com wrote:

Can you use spaces instead of tabs as it creates lots of changes when there doesn't need to be? I just the the default Java formatting for IntelliJ. Can you update your fork and issue the pull request again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/OpenHFT/Chronicle-Salt/pull/2#issuecomment-360412490 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAEemg2sW- TIPozKvFHiukgF0L54BguBks5tOEs6gaJpZM4Rq4EF .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenHFT/Chronicle-Salt/pull/2#issuecomment-360425855, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBU8VFpm-q8IDDH0XUwccSl4SLP8QzLks5tOFeBgaJpZM4Rq4EF .

--

Peter Lawrey CEO +44 7557017054 <07771%20662994> chronicle.software

Trading as Chronicle Software Ltd

motoras commented 6 years ago

I did add a maven plugin which formats using the default eclipse formatting because that was what I have found: http://code.revelc.net/formatter-maven-plugin/ Now at compile the source is also formatted. It also provides goals such: mvn formatter:validate and mvn formatter:format. Of course this can be customized, so probably we can setup to our tastes. I am pretty much ok with any formatting my only preference is to have lines longer than 80 lines up to 140. Probably if you export your IntelliJ format preferences, I could find a way to import them in eclipse then, exported to a config file, which the maven task can use it.

On Thu, Jan 25, 2018 at 4:39 PM, Peter Lawrey notifications@github.com wrote:

Can you use the same formatting as the default for IntelliJ which I believe follows the old Sun recommended standard.

On 25 January 2018 at 10:29, motoras notifications@github.com wrote:

Sorry, I can't believe I had my editor configured to use tabs. I'll fix that.

I am also going to add a formatting goal in maven so when you build, it will format the files, so github sources will always have the same formatting profile.

I'll reissue the pull request later today.

On Thu, Jan 25, 2018 at 11:36 AM, Peter Lawrey <notifications@github.com

wrote:

Can you use spaces instead of tabs as it creates lots of changes when there doesn't need to be? I just the the default Java formatting for IntelliJ. Can you update your fork and issue the pull request again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/OpenHFT/Chronicle-Salt/pull/2# issuecomment-360412490 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAEemg2sW- TIPozKvFHiukgF0L54BguBks5tOEs6gaJpZM4Rq4EF .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/OpenHFT/Chronicle-Salt/pull/2#issuecomment-360425855 , or mute the thread https://github.com/notifications/unsubscribe-auth/ABBU8VFpm- q8IDDH0XUwccSl4SLP8QzLks5tOFeBgaJpZM4Rq4EF .

--

Peter Lawrey CEO +44 7557017054 <+44%207557%20017054> <07771%20662994> chronicle.software

Trading as Chronicle Software Ltd

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenHFT/Chronicle-Salt/pull/2#issuecomment-360485221, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEemm0CWZswu1PuNDp2TwBDFKIHUsodks5tOJIRgaJpZM4Rq4EF .