OpenHFT / Chronicle-Wire

A Low Garbage Java Serialisation Library that supports multiple formats
http://chronicle.software
Apache License 2.0
506 stars 123 forks source link

Text formatting of multiple objects within a sequence omits element separator #35

Closed ryanlea closed 7 years ago

ryanlea commented 7 years ago

Perhaps I'm misusing marshallable within sequence? However, it doesn't print out the element separators for multiple objects within a sequence. The result is invalid yaml.

The output can, however, be read back in by Chronicle-wire. Interesting to note that the JsonWire extension overrides pushState() to set leaf() in this case as well - unsure if that would resolve.

gist of the test case attached below.

Cheers

Ryan

Gist: https://gist.github.com/ryanlea/5547d80f04f65b2d506528effc0f4330

peter-lawrey commented 7 years ago

Thank you for the test case. I will look into it tomorrow.

On 20 Oct 2016 21:26, "Ryan Lea" notifications@github.com wrote:

Perhaps I'm misusing marshallable within sequence? However, it doesn't print out the element separators for multiple objects within a sequence. The result is invalid yaml.

The output can, however, be read back in by Chronicle-wire. Interesting to note that the JsonWire extension overrides pushState() to set leaf() in this case as well - unsure if that would resolve.

gist of the test case attached below.

Cheers

Ryan

Gist: https://gist.github.com/ryanlea/5547d80f04f65b2d506528effc0f4330

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHFT/Chronicle-Wire/issues/35, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBU8aMHvzbtU6AZT4uh3rt8plLt__mpks5q185fgaJpZM4KckRQ .

peter-lawrey commented 7 years ago

I suspect this was fixed a couple of weeks ago. Can you check this test? It loads with snakeYaml.

peter-lawrey commented 7 years ago

Closing for now as test passes. Can reopen if this isn't fixed.

ryanlea commented 7 years ago

Apologies for tardy response. Yes, this appears fixed - tested with 1.7.18.

hft-team-city commented 3 years ago

Released in Chronicle-Wire-2.20.101, BOM-2.20.134

hft-team-city commented 2 years ago

Released in Chronicle-Wire-2.22ea11, BOM-2.22ea69