search

OpenHFT / Java-Thread-Affinity

Bind a java thread to a given core
http://chronicle.software/products/thread-affinity/
Apache License 2.0
1.78k stars 359 forks source link

OSGi export packages #14

Closed ront closed 9 years ago

ront commented 9 years ago

Hi,

I have been deploying the affinity jar as a bundle into an OSGi container that already has SLF4J as a separate bundle. The SLF4J minor versions are different. The difference causes Link errors between the versions when loaded in an OSGi container.

Removing them from both the jar file and the MANIFEST fixes the issue and we get happy bundles. I'm happy to submit a pull request but just wanted to check there was not a specific reason for including them in the first place?

Cheers,

Ron

lburgazzoli commented 9 years ago

It is effectively a bug, the jar should not contain slf4j nor jetbrains classes. Please submit a PR and I'll tests/review it.

For my understanding, which OSGi container do you use?

lburgazzoli commented 9 years ago

I've created the following JIRA:

lburgazzoli commented 9 years ago

I've created a branch on my fork https://github.com/lburgazzoli/Java-Thread-Affinity/tree/HFT-OSGI with a fix for this issue and a simple unit test.

Can you validate it on your OSGi container?

ront commented 9 years ago

Thanks for the quick response. I'm running on the Virgo OSGi container. I will give it a try today and let you know.

Thanks again. Ron

danielshaya commented 9 years ago

Hi Ron,

Thanks for your interest and feedback - looks like we've made some good progress here.

I've recently been approaching our contributors for feedback that would be really helpful to our company.

If you don't mind answering you a few questions that I can send you, please send your preferred contact details to me at daniel.shaya@higherfrequencytrading.com.

Regards Daniel

On Tue, Sep 16, 2014 at 9:00 AM, ront notifications@github.com wrote:

Thanks for the quick response. I'm running on the Virgo OSGi container. I will give it a try today and let you know.

Thanks again. Ron

— Reply to this email directly or view it on GitHub https://github.com/OpenHFT/Java-Thread-Affinity/issues/14#issuecomment-55708793 .

ront commented 9 years ago

Hi Luca,

This change works nicely in Virgo. Thanks again

lburgazzoli commented 9 years ago

I will merge it soon

lburgazzoli commented 9 years ago

Should be available in the next snapshot