search

OpenHFT / Zero-Allocation-Hashing

Zero-allocation hashing for Java
Apache License 2.0
787 stars 136 forks source link

Refactor to simplify implementing hash functions #57

Closed gzm55 closed 3 years ago

gzm55 commented 3 years ago
  1. move the byte order converting logic into Primitives and Access class
  2. replace common fetch* methods in hash class by the Access short api

After refactoring, the hashing functions could only care about the calculations in static methods and create suitable LongHashFunction/LongTupleHashFunction instances.

gzm55 commented 3 years ago

@leventov could u plz take some time to review this pr?

leventov commented 3 years ago

@gzm55 sorry, I can't.

RobAustin commented 3 years ago

@glukos could you take a look at this pull request and merge it if ok, thanks

gzm55 commented 3 years ago

@glukos @RobAustin any updates?

gzm55 commented 3 years ago

@glukos @RobAustin any updates?

or else i would merge this pr first since all the ut is passed

RobAustin commented 3 years ago

Ok merge it.

On 28 Mar 2021, at 12:26, James Z.M. Gao @.***> wrote:

 @glukos @RobAustin any updates?

or else i would merge this pr first since all the ut is passed

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.