search

OpenHFT / Zero-Allocation-Hashing

Zero-allocation hashing for Java
Apache License 2.0
787 stars 136 forks source link

Murmur3 is incompatible with C++ reference implementation for negative seed values #68

Open oertl opened 2 years ago

oertl commented 2 years ago

It seems that the Murmur3 implementation has the same problem as that in Guava (see https://github.com/google/guava/issues/3493).

gzm55 commented 2 years ago

@oertl now the negative seeds can pass ut with the latest guava (31.0.1-jre). The implementation of this project decides to keep compatible with the upstream guava version, and we should have to wait the decision from google/guava#3493.

oertl commented 2 years ago

The same bug also existed in Apache Commons Codec where it was fixed in version 1.14, see https://issues.apache.org/jira/browse/CODEC-264.