Closed Habakuk2000 closed 4 years ago
I don't provide this option - technical reason: the const structures in modelDSO6022.cpp
, where the behavior is defined, are defined for all possible models before main()
starts, so an command line option can't change anything anymore. The appropriate device model is later activated using the USB identifier, which does not provide any indication of AC/DC. The firmware doesn't differentiate either, it just won't switch to AC if it's not defined in the model file.
I keep your suggestion in mind, but follow it with low priority - because it works for me as it is. ;).
? The 6022 didn't have AC coupling mode?
with al little modification ... have a look at:
https://github.com/OpenHantek/OpenHantek6022/blob/master/docs/HANTEK6022_AC_Modification.pdf
Am 25.01.2020 um 12:13 schrieb kiwichrish:
? The 6022 didn't have AC coupling mode?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenHantek/OpenHantek6022/issues/45?email_source=notifications&email_token=AOCLPU4T3AKKLYGP2YLVBLDQ7QNFXA5CNFSM4J4PMGPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ42LXI#issuecomment-578397661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOCLPU3X53GKWCHCB7K6BBTQ7QNFXANCNFSM4J4PMGPA.
ROFL.. I just use a cap in series with the probe externally when I want AC coupling on mine. :-)
So once the mod is done does the re-compiled version of OpenHantek let you turn the mos relays on/off? Definitely worth doing.. that schematic explains why the damn thing clips some signals as well, depending on V/div setting..
So once the mod is done does the re-compiled version of OpenHantek let you turn the mos relays on/off?
Sure, that's the purpose of my modification.
that schematic explains why the damn thing clips some signals as well, depending on V/div setting.
If you take a closer look at the data sheet of the ADC, you will see another design error - the input voltage of the ADC (Ain=-0.5V..+0.5V, /Ain=0) is far outside the specification (common mode voltage: +0.7V..+1.1V). This may be the reason why the 1st 1000..2000 samples are garbage - I just throw them away during sampling.
Why not just leave AC and DC options always available on gui?
AC coupling requires a hardware modification that the majority of users do not have. The machine should only offer AC coupling if it is also available. Otherwise there will be many irritations and issue reports.
Even when choosing DC? In the source code, it seems that this macro is only used to prevent AC selection.
FYI: As I only have cmake 3.10 (Ubuntu 18.04), I am unable to compile with HANTEK_AC defined. Function add_compile_definitions function has been added in cmake 3.12.
@jim-o: good idea. leaving the AC/DC coupling mode 'always on' but you have to enable it with a checkbox in the settings menu... that should not lead to irritations. btw: it took me a few days getting "visual studio", "cmake" and especially "qtcreator" to run. but i am unable to create 'release build' with qtcreator. whatever i do, it always creates 'debug build'. no way. using visual studio, everything works fine.
@Habakuk2000: No need to worry, the debug overhead is removed latest at (linux) package creation. If you want to run the bare binary you can strip it like I do for testing my linux build:
cd build
make -j4 && strip openhantek/OpenHantek && openhantek/OpenHantek
That's it - for Windows VS should do the task. BTW: what is your system?
@jm-o:
Even when choosing DC?
What do you mean??? If you select DC, it will measure with DC coupling, but if you would select AC on an unmodified Hantek, the SW will send the "switch-to-AC" command and the Hantek will set the appropriate port bits (without any effect) and will continue to use DC coupling - but the scope screen will tell you "AC coupling". Many Hantek6022 users are newbies or makers and don't read documentation and will be confused. See the lengthy discussion about probe attenuation (fixed, variable or even at all), I don't need it because I'm used to do the range adaption in my brain since decades :)
Regarding your Ubuntu cmake version, you can change the entry in CMakeList.txt
to:
if ( DEFINED HANTEK_AC )
if(${CMAKE_VERSION} VERSION_LESS "3.12.0")
add_definitions( -DHANTEK_AC )
else()
add_compile_definitions( HANTEK_AC )
endif()
endif()
(currently untested as I'm away from my development system) EDIT: yes, works like expected
@Ho-Ro: My System is Windows 10 Pro
What do you mean??? I didn't understand what you meant when you said "Otherwise there will be many irritations and issue reports.". It wasn't software issues but users issues :-)
An AC checkbox in Settings/Scope, disabled by default, seems to be a good enough solution to keep the user informed.
Is ist possible to enable the ac/dc coupling without rebuilding the binaries. ex. by an option?