search

OpenHantek / openhantek

OpenHantek is a DSO software for Hantek (Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes
http://openhantek.org/
GNU General Public License v3.0
763 stars 199 forks source link

A little bit of refactoring for ChannelWidgets. #243

Closed uunicorn closed 6 years ago

uunicorn commented 6 years ago

Make ChannelWidgets look more like a composite widget and layout properly. Previously it was a widget which was never added to any layout. Therefore it had default position (0,0) and size (100, 30) inside it's parrent (DsoWidget). Whenever a trigger position/level slider was in the left top corner, it was getting under invisible ChannelWidgets. It this case it was impossible to get it out from there since all the mouse events were directed to the ChannelWidgets.

davidgraeff commented 6 years ago

Thanks for this PR. The ChannelWidgets class is definitely a place where the codebase deserves some love and simplifications.