search

OpenHantek / openhantek

OpenHantek is a DSO software for Hantek (Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes
http://openhantek.org/
GNU General Public License v3.0
763 stars 199 forks source link

Windows Fix #252

Closed circuit-specialists closed 5 years ago

circuit-specialists commented 6 years ago

Fixed lib.exe error Fixed compile error Preconfigured settings for VS Code

circuit-specialists commented 6 years ago

I've done some more testing. The reason lib.exe fails is based on the generator cmake is using on windows. There are four options with VS, not including mingw. There is Hostx86/x86, Hostx86/x64, Hostx64/x86, and Hostx64/x64. As long as the generator is using "Visual Studio 15 2017 Win64" and path Hostx64/x64, then it configures and generates correctly, but the compiler must use Hostx86/x64. That's where the conflict occurs, since lib.exe, and cl.exe are different types, and paths. In the windows documentation section it should specify which generator cmake needs to make. The .vscode directory helps with that exactly by specifying the generator for cmake to use.

circuit-specialists commented 6 years ago

I've made the changes to the fftw3.h directory to place it into the true openhantek/src.

LameLefty commented 6 years ago

I managed to build a working Win10-64 bit version today using these fixes. However, my MS Visual Studio installation location and version numbers are both different than those specified in the changed code. Manually editing several of the appropriate files fixed those issues. In addition, for some reason even after parsing the main CMakeLists.txt file to create a Visual Studio project "solution" file did not allow Visual Studio to build the project properly until I again manually edited the base CMakeLists.txt file to specify the location of the Qt5 libraries. Finally, after all of that, I was able to build a working binary and run it successfully with my Hantek 6022BE.

davidgraeff commented 5 years ago

I'm sorry guys, I can't accept a pull request that binds this project to one specific visual studio version. That will be soon outdated. If you find a more general approach I would be happy to accept it.