OpenHantek / openhantek

OpenHantek is a DSO software for Hantek (Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes
http://openhantek.org/
GNU General Public License v3.0
771 stars 199 forks source link

Fix to windeployqt step for MSVC builds #259

Closed wavelet2 closed 6 years ago

wavelet2 commented 6 years ago

When building with both Visual Studio 2015 Community Edition and Visual Studio 2017 Community Edition, the directory containing the built .exe file is of the form: ...\build-openhantek-Desktop_Qt_n_n_n_MSVC201[57]_64bit-Default\openhantek rather than ...\build-openhantek-Desktop_Qt_n_n_n_MSVC201[57]_64bit-Default\openhantek\Debug or ...\build-openhantek-Desktop_Qt_n_n_n_MSVC201[57]_64bit-Default\openhantek\Release The final step of the built process (running windeployqt) currently fails and my proposed change fixes this. I have not been able to test the build process with MSVC compilers earlier than 2015. Openhantek fails to compile on MSVC 2013 Update 3 and later due to the compiler not supporting list initialisation (https://msdn.microsoft.com/en-gb/library/Dn793970.aspx)

davidgraeff commented 6 years ago

Thanks :)