fix Dark mode background introduced with MacOS 10.14 (mojave)

OpenHantek / openhantek

OpenHantek is a DSO software for Hantek (Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes

http://openhantek.org/

GNU General Public License v3.0

763 stars 199 forks source link

fix Dark mode background introduced with MacOS 10.14 (mojave) #264

Closed ra1nb0w closed 5 years ago

ra1nb0w commented 5 years ago

this fix set the correct background when you change the style. without the patch and with Dark mode the text and background are white; with this patch the text remain white but the background will be set to dark.

thanks to @gmittone

ra1nb0w commented 5 years ago

requires linux/windows testing

davidgraeff commented 5 years ago

should work for all operating systems. Thanks. Could you please sign off your commit :)

ra1nb0w commented 5 years ago

Could you please sign off your commit :)

sorry for the question, I know only three way to change the commit on a pull request:

close this and open a new one
amend a commit (not good)
squash things together so they appear as a single commit

is there another way? or which one do you suggest? thanks

davidgraeff commented 5 years ago

amend is the right thing. On the command line you would do: git commit --amend -s to sign the last commit. This changes the history, which is correct. Do a forced push: git push -f.

ra1nb0w commented 5 years ago

done. thank you