search

OpenHeartDevelopers / CemrgApp

An Interactive Medical Imaging Platform with Image Processing and Computer Vision Toolkits for Cardiovascular Research.
http://www.cemrgapp.com
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

`mitkCommandLineParser`: Replace `InputFile` and `OutputFile` with `String` #75

Closed JostMigenda closed 7 months ago

JostMigenda commented 7 months ago

Fixes compilation errors on both Linux and macOS, as discussed on Slack.

github-actions[bot] commented 7 months ago

:zap: Code Analysis Results :zap:

:red_circle: Cppcheck found 18 issues! Click here to see details.
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp#L1813-L1818 ```diff !Line: 1813 - style: Redundant initialization for 'scalars'. The initialized value is overwritten before it is read. [redundantInitialization] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp#L1806-L1811 ```diff !Line: 1806 - note: scalars is initialized ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp#L1813-L1818 ```diff !Line: 1813 - note: scalars is overwritten ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.h#L55-L60 ```diff !Line: 55 - style: The class 'AtrialFibresClipperView' does not have a constructor although it has private member variables. [noConstructor] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.h#L66-L71 ```diff !Line: 66 - style: The class 'AtrialFibresView' does not have a constructor although it has private member variables. [noConstructor] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp#L450-L455 ```diff !Line: 450 - style: Redundant initialization for 'radii'. The initialized value is overwritten before it is read. [redundantInitialization] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp#L449-L454 ```diff !Line: 449 - note: radii is initialized ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp#L450-L455 ```diff !Line: 450 - note: radii is overwritten ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresLandmarksView.h#L53-L58 ```diff !Line: 53 - style: The class 'AtrialFibresLandmarksView' does not have a constructor although it has private member variables. [noConstructor] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresLandmarksView.cpp#L392-L397 ```diff !Line: 392 - style: The scope of the variable 'distance' can be reduced. [variableScope] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresVisualiseView.h#L50-L55 ```diff !Line: 50 - style: The class 'AtrialFibresVisualiseView' does not have a constructor although it has private member variables. [noConstructor] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L1795-L1800 ```diff !Line: 1795 - style: Condition '!userInputAccepted' is always true [knownConditionTrueFalse] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L1793-L1798 ```diff !Line: 1793 - note: Assignment 'userInputAccepted=false', assigned value is 0 ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L1795-L1800 ```diff !Line: 1795 - note: Condition '!userInputAccepted' is always true ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L2340-L2345 ```diff !Line: 2340 - style: Variable 'segImage' is assigned a value that is never used. [unreadVariable] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L193-L198 ```diff !Line: 193 - style: Redundant initialization for 'reply1'. The initialized value is overwritten before it is read. [redundantInitialization] ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L190-L195 ```diff !Line: 190 - note: reply1 is initialized ```
https://github.com/OpenHeartDevelopers/CemrgApp/blob/ffd6dc989750e55327b3f6252d3d54b4da24df2e/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L193-L198 ```diff !Line: 193 - note: reply1 is overwritten ```