OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Seemingly valid image URL not loading #175

Closed jeffreyameyer closed 1 year ago

jeffreyameyer commented 3 years ago

Bug description What is happening? -

What should be happening?

danrademacher commented 3 years ago

Interesting. What I notice is that both of the images that work are https in the tag value. This one is http. And we're passing that through correctly it seems: image

But if we look in the network tab, we're actually asking for https: image

And try that link with https and you get this: image

Take the s away, works fine. But if we solved for using actually http here in the img request, we'd end up with mixed content and get blocked by browsers as a security threat. I am a bit surprised that http://pcad.lib.washington.edu/ doesn't use HTTPS anywhere far as I can see. Including on their login page, http://pcad.lib.washington.edu/admin/login/

That's not our problem, but one of the challenges of pulling images from various places on the web is that we're likely to end up with either (a) an error like this or (b) mixed content and therefore SSL warnings

jeffreyameyer commented 3 years ago

@dan - would it make sense / be possible to show an error message on a failed image load attempt?

jeffreyameyer commented 1 year ago

Whatever this problem was, it doesn't seem to repro here or there was a workaround & it's been open without comment for almost 2 years. Closing.