OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Also use construction_date as alternative to start_date #330

Open danrademacher opened 2 years ago

danrademacher commented 2 years ago

From natfoot on OSM slack:

There are somethings that are started but are not start_date_date= yet and are rendering at all times. to at least get it to "disappear" before the construction_date=

A few steps to see about this:

  1. Check taginfo to see how prevalent the tag is: https://taginfo.openhistoricalmap.org/keys/construction_date. So 58 items have that tag. Here's a link to those on Overpass
  2. See if the field is in the vector tiles. Here's an example way https://www.openhistoricalmap.org/way/198742611, and here in vtiles, https://vtiles.openhistoricalmap.org/#16/47.64018/-122.12904 image

    The answer is, no, we are not passing this field into vector tiles, so without adding it we can't make the timeslider operate on it.

To make this happen we need to:

Questions:

1ec5 commented 2 years ago

I wasn’t aware of construction_date, even in OSM. Since OHM has a richer data model, I’ve been mapping a distinct under-construction building coincident with and connected to the finished building. This also allows additional flexibility when some parts of a building are finished before others, the building’s name changes during construction, or construction hasn’t completed yet. The vector tiles technically already support this modeling, but currently the style doesn’t visually distinguish building=construction from other buildings. Besides buildings, other features could benefit from the same treatment using the construction: lifecycle prefix.