search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
18 stars 1 forks source link

Allow for multiple OHM-time enabled layers #334

Closed danrademacher closed 2 years ago

danrademacher commented 2 years ago

Over in #331, Vanessa (with some OHM support from TIm) is working on a new woodblock map style that we envision as the first of several/many historic map styles we'd offer on OHM. We'd eventually have them show up here: image

We also need to update in locales like this: https://github.com/OpenHistoricalMap/ohm-website/blob/staging/config/locales/en.yml#L2374-L2379

Need to poke around and see how to add more layers here and also confer with Gregor on multiple timeslider enabled layers

danrademacher commented 2 years ago

We just discussed testing this feature with a couple of copies of the existing map style and switching between them, pending a truly different map style still under development

gregallensworth commented 2 years ago

Currently there is a single L.MapboxGL layer and it has one style: ohmStyle and its keyid is historical which is used throughout. So one of the first steps will be to create a second style, and integrate it into the application so there are multiple vector tile layers, and one may switch between them, regardless of the slider. It would also make sense to rename ohmStyle since it will no longer be THE OHM-style.

Second would be getting the 'slider to act upon both:

For my reference:

gregallensworth commented 2 years ago

The constant in ohm.style.js is now called ohmVectorStyles and is a dict/assoc containing two styles:

gregallensworth commented 2 years ago

@danrademacher All righty, I seem to have this working well here. When you get that new style ready, let me know and I can paste it in here for a more realistic test.

danrademacher commented 2 years ago

Awesome! Is this on a branch in ohm-website that I can check out locally?

gregallensworth commented 2 years ago

Not yet. I didn't see a point in committing a placeholder style, so I was going to wait for the new style (at least a preliminary version) for some final testing.

jeffreyameyer commented 2 years ago

This is very exciting!!

On Tue, Feb 15, 2022 at 5:55 PM Greg Allensworth @.***> wrote:

Not yet. I didn't see a point in committing a placeholder style, so I was going to wait for the new style (at least a preliminary version) for some final testing.

— Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/issues/issues/334#issuecomment-1041011909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM4EWZPRCBTD4OS72JMN3U3L72XANCNFSM5OF65EWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

gregallensworth commented 2 years ago

See the new branch: gin-multistyle-woodblock

danrademacher commented 2 years ago

This is done and deployed