Tasking manager project settings for user permissions not working as expected

[danrademacher]

Split out from #338:

We were checking some last details before lunching the digitization campaign and we realized that new users aren't aloud for mapping, even though the project settings are "beginner" for mapper level, and "any user" for mapping permissions. Do you have any clues about this restriction?

@helgouj I have split this out into a separate issue to make sure it doesn't get lost in the mix of that overall issue

For Project 23, https://tasks.openhistoricalmap.org/projects/23, we have this setting:

But then as shown in the screenshot above, non-admin users are getting blocked from editing.

I confirmed this with a test non-admin account and got this result:

Interesting, the content of the error code is:

{"Error": "User not accepted license terms", "SubCode": "UserLicenseError"}

That was in response to a POSt request to https://tm-api.openhistoricalmap.org/api/v2/projects/23/tasks/actions/lock-for-mapping/496/

[danrademacher]

We have narrowed this down to an issue with the License setting in TM -- it's not prompting users to agree to the CC0 license, and then because they have not agreed to the license, they are blocked from editing. Removing the license setting from the project "fixes" the permissions issue, and allows people to edit, but obviously we want to fix the underlying problem.

I removed the license requirement via Tasking Manager admin for now and we're looking into the underlying cause.

[helgouj]

I just got some feedback from some of the osm community users and in Project 24 it seems that new users are still not allowed to map in Tasking Manager. Project 23 works fine!

[willemarcel]

@danrademacher This should be fixed now in production. Could you confirm, please?

[danrademacher]

Confirmed this is fixed. I added CC0 requirement to Project 4 and then used a nonadmin account to confirm that (a) I am asked to agree to the license and (b) I can map tasks once I agree to the license:

@helgouj if you want to re-enable the CC0 settings on your tasks, you can do so now. You can also choose to leave the setting alone at this point.

[helgouj]

Great news! Thank you for your help!

De: "Dan Rademacher" @.> À: "OpenHistoricalMap/issues" @.> Cc: "hanae el gouj" @.>, "Mention" @.> Envoyé: Mercredi 8 Juin 2022 02:42:34 Objet: Re: [OpenHistoricalMap/issues] Tasking manager project settings for user permissions not working as expected (Issue #366)

Confirmed this is fixed. I added CC0 requirement to Project 4 and then used a nonadmin account to confirm that (a) I am asked to agree to the license and (b) I can map tasks once I agree to the license: [ https://user-images.githubusercontent.com/1423200/172507241-f1fb8900-8c79-425c-9761-5cf22db612ab.png ]

[ https://github.com/helgouj | @helgouj ] if you want to re-enable the CC0 settings on your tasks, you can do so now. You can also choose to leave the setting alone at this point.

— Reply to this email directly, [ https://github.com/OpenHistoricalMap/issues/issues/366#issuecomment-1149319849 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AQMMNYJYZWV2Z7TOYQ32ZYDVN7T7VANCNFSM5V4K7TUA | unsubscribe ] . You are receiving this because you were mentioned. Message ID: @.***>