Closed danrademacher closed 10 months ago
Looks like this are set here: https://github.com/OpenHistoricalMap/ohm-website/blob/staging/config/initializers/omniauth.rb#L22-L37
And we would need to set up various authkeys:
provider :google_oauth2, GOOGLE_AUTH_ID, GOOGLE_AUTH_SECRET, google_options if defined?(GOOGLE_AUTH_ID)
provider :facebook, FACEBOOK_AUTH_ID, FACEBOOK_AUTH_SECRET, facebook_options if defined?(FACEBOOK_AUTH_ID)
provider :windowslive, WINDOWSLIVE_AUTH_ID, WINDOWSLIVE_AUTH_SECRET, windowslive_options if defined?(WINDOWSLIVE_AUTH_ID)
provider :github, GITHUB_AUTH_ID, GITHUB_AUTH_SECRET, github_options if defined?(GITHUB_AUTH_ID)
provider :mediawiki, WIKIPEDIA_AUTH_ID, WIKIPEDIA_AUTH_SECRET, wikipedia_options if defined?(WIKIPEDIA_AUTH_ID)
Wordpress and AOL don't work at all, they just produce this error with no moment for user entry of any credentials:
So I think we should just remove these two lines of code: https://github.com/OpenHistoricalMap/ohm-website/blob/merge-osm-website/app/views/sessions/new.html.erb#L47-L48
And then consider which if any of the other providers we enable.
That said, I suspect most OHM editors just make a standard local account
Those nonworking items are now gone on this WIP branch https://github.com/OpenHistoricalMap/ohm-website/tree/merge-osm-website-authoptions
@jeffreyameyer what's your take on how important it is to allow folks to log into OHM with various OAuth providers?
Looks like some friction to get these configured, though doing a couple probably not so hard, and then additional maintenance and account management with each platform
Closing this due to inactivity and no apparent user need for additional auth providers
Here’s an example of an OpenStreetMap user who has been hesitant to dive into OpenHistoricalMap because it lacks a third-party authentication provider they recognize. (They mention GitHub, but perhaps they’d find some other option satisfactory too.)
Some statistics about third-party authentication usage in OSM: https://github.com/openstreetmap/openstreetmap-website/issues/3550#issuecomment-1315910044 https://github.com/openstreetmap/operations/issues/162#issuecomment-301610814.
I'm the user that @1ec5 mentioned. To be clear, I was just trying to comment on a changeset, I'm not anticipating that I will make many, if any, contributions to OHM. So I'm not expecting anyone to implement any difficult features on my behalf. But it would be nice if OHM supported the same identity providers as OSM, so you can easily create/login to an account using a well-known identity provider such as Github, and not have to create and remember a new password. I'm not opposed to creating an OHM account manually, but given I don't anticipate contributing much, I probably won't bother with that.
Though, I would guess that the proposed #662 is probably easier to implement, and a better improvement for the overall ecosystem. And with #662 implemented, you essentially get all of OSM's identity providers for free (transitively speaking).
Our branch that catches up with OSM has some pretty outdated looking login options:
Which probably means those are set somewhere in our config from from our old OSM website fork
OSM main site looks more sensible:
Need to look into how those are configured.