search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Time Slider, Change Date box submit and cancel buttons are not translated? #630

Closed gregallensworth closed 2 months ago

gregallensworth commented 1 year ago

Bug description

In the Change Date modal, the Update Date and Cancel buttons seem to display in English even if I'm using French. Se screenshot below.

Probably just a missing translation string?

Repro Steps

  1. use the page in a supported language that is not English; right now that's Spanish and French 2.in the time slider, click the pencil to open the Change Date modal
  2. see that Update Date and Cancel are in English

Screenshots & URL

image

gregallensworth commented 1 year ago

Test this in both supported languages:

gregallensworth commented 1 year ago

Well that was simple. I just never translated this.

    datepicker_submit_text: "Update Date",
    datepicker_cancel_text: "Cancel",
danrademacher commented 2 months ago

Image