search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Unexpected error behavior (iD) with EDTF #674

Closed hdevine825 closed 9 months ago

hdevine825 commented 10 months ago

Bug description What is happening? When an object has the same year in both start date and EDTF an error appears. For example start_date=1888 and start_date:edtf=/1888 recommends fixing by putting 1888-12-31 as start date. What should be happening? Either the tagging should be allowed (essentially start_date<=maximum(start_date:EDTF)). Alternatively the suggested fix should be the same precision as the provided value (replace 1888 with 1887 in the example above.) Repro Steps Please provide detailed instructions to reproduce the behavior:

  1. In iD add equal years to start_date and start_date:EDTF, prefixing the EDTF value with "/"
  2. The error appears.
1ec5 commented 10 months ago

This Slack discussion clarified that /1888 is an acceptable spelling of “in or before 1888” per level 1 of the EDTF specification. Technically, ../1888 refers to a time period with an unspecified beginning, whereas omitting the start of the range affirms that it’s unknown.

Nevertheless, edtf.js’s considers /1888 not to “contain” any date at all – even the range’s maximum date. So clicking the suggestion fails to suppress the warning.