search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

place labels are missing from Historic (main) stylesheet #724

Closed 1ec5 closed 6 months ago

1ec5 commented 7 months ago

The Historic stylesheet no longer labels place=* points. Here’s Ellis, California as of January 1, 1880:

Historic Railway
Place of worship icon “Ellis” label

This regression seems to have been introduced in OpenHistoricalMap/map-styles@187479b5ab7cf6f593356a7ad404936d2ab8727f, which changed the relevant layers’ visibility properties from visible to none.

Originally reported on OSM World Discord.

1ec5 commented 7 months ago

Can we get an ETA on a fix? I’ve heard from a number of mappers who are impacted by this bug.

vknoppkewetzel commented 7 months ago

Hey @1ec5 I can get this updated today to push into production pipeline, thanks for pinging

Rub21 commented 7 months ago

@vknoppkewetzel , seems we need to make some modification here, and it will pull the changes? https://github.com/OpenHistoricalMap/ohm-deploy/blob/staging/images/web/Dockerfile#L57 , also looks like it get the changes from staging https://github.com/OpenHistoricalMap/map-styles , can we make a direct PR to production in https://github.com/OpenHistoricalMap/ohm-deploy, because currently we have a lot testing in staging that are not ready to be in production.

danrademacher commented 7 months ago

@Rub21 once Vanessa has an updated map style, I can work with you to get the style updated without dragging things off staging that are not ready

vknoppkewetzel commented 7 months ago

👋 the main (historic?) style does have the place points image

But I did intentionally remove symbology from the rail style originally when drafting, and will get that back in and sync with Dan on updating that. Going to change the title of this ticket (unless I m missing something else then please point it out of course)

1ec5 commented 7 months ago

No, as seen in both my screenshot and yours, place labels are missing from the Historic stylesheet, not the Railway stylesheet.

vknoppkewetzel commented 7 months ago

@1ec5 thanks for responding, I interpreted as points of interest vs city labels, getting this updated now

vknoppkewetzel commented 7 months ago

This is in prod (and the rail style also still will have symbolology added in)

1ec5 commented 7 months ago

Thanks for OpenHistoricalMap/map-styles@dda97d62286fcfa53ddab82c75117ae1dc2e469d – looking forward to it getting deployed!