search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Month and day clear when entering era first time on iD #737

Closed danrademacher closed 7 months ago

danrademacher commented 7 months ago

From #663:

🔴 The Start Date and End Date do not allow adding month and day, the entered values are cleaned when clicking out the field

@1ec5 asks:

I wonder if this is related to https://github.com/openstreetmap/iD/issues/10145. Have we pulled in the fix in https://github.com/openstreetmap/iD/pull/10151?

This is only on staging.

note that this appears to happen upon selecting AD/BC the first time I am editing the field:

https://github.com/OpenHistoricalMap/issues/assets/1423200/a020cbf5-df0d-43b6-a1f1-174a4e1150c3

danrademacher commented 7 months ago

@erictheise any update on this from your efforts on Friday?

erictheise commented 7 months ago

I'm beginning to suspect this was introduced with https://github.com/OpenHistoricalMap/iD/pull/193/. start_date only has the year component by the time it returns from field.js which is what resets the input fields for month and day.