search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Nominatim should suppress nodes/labels in search results #739

Open jeffreyameyer opened 7 months ago

jeffreyameyer commented 7 months ago

OHM Nominatim currently returns both boundary relations and boundary relation labels (both are tagged with place=) in its search results, but the labels are redundant and unnecessary in the results.

See here:

Monosnap north carolina | OpenHistoricalMap 2024-04-09 15-18-00

For comparison, here are OSM's results for the same search, even though the label node has a place=state tag.

Monosnap north carolina | OpenStreetMap 2024-04-09 15-21-27
1ec5 commented 7 months ago

As seen in OSM, Nominatim normally merges any node (label or admin_centre) into the boundary relation that contains it. I wonder if this isn’t working correctly because the names differ. I’m hoping we can move away from the practice of stuffing date ranges into name=*. Date glosses can foil name matching, as explained in https://github.com/OpenHistoricalMap/issues/issues/407#issuecomment-1246516071, and are redundant to iD’s labels, which automatically include the dates: OpenHistoricalMap/iD#184. We just need to get the main website to label dates automatically as well: #431. (I’m unsure if a fix for that particular issue would extend to Nominatim results.)