Closed danrademacher closed 6 months ago
My one concern with the light box is that it obscures the map portion of the display. I think part of the goal is to simultaneously show the building footprint and the surrounding map along with the picture, so that people can kind of try to visually merge the two.
On Mon, Oct 28, 2019, 9:46 AM Dan Rademacher notifications@github.com wrote:
To work with this in approximation of final environment, see this handy script paste-infrom gregor: OpenHistoricalMap/issues#754 (comment) https://github.com/OpenHistoricalMap/issues/issues/754
I think visual design here is going to be light touch as expected. A few highlights:
- Chevrons on images, something a bit more refined: [image: image] https://user-images.githubusercontent.com/1423200/67698309-5be20e80-f967-11e9-84bc-bd033891cece.png
- Visual indicator that Lightbox is an option (click image to see it happen)
- Update lightbox treatment, with some transparency on scrim nicer close X. Currently looks like [image: image] https://user-images.githubusercontent.com/1423200/67698389-846a0880-f967-11e9-9762-b3b89c7c91d0.png
Maybe just borrow heavily from Google Material Design buttons for these that we've been using elsewhere recently?
Project code at Greeninfo is Open Historical Map:Inspector
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/issues/issues/753?email_source=notifications&email_token=AALM4EWR2Q2LQZQRHOPA3VTQQ4JMZA5CNFSM4JF5ADC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HU2IBHQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM4ESKYHCNIDTYGKNKACLQQ4JMZANCNFSM4JF5ADCQ .
I redid the lightbox behavior to be much nicer than my original, grey version. This borrows from the intent we had with Fluidbox, to expand outward from the slide's position so as t keep a sense of continuity from that position.
To work with this in approximation of final environment, see this handy script paste-infrom gregor: https://github.com/OpenHistoricalMap/issues/issues/754
I think visual design here is going to be light touch as expected. A few highlights:
Maybe just borrow heavily from Google Material Design buttons for these that we've been using elsewhere recently?
Project code at Greeninfo is
Open Historical Map:Inspector