Handling images

[danrademacher]

related to having an unknown number of images as shown in OpenHistoricalMap/issues#758, noting that with fully client side approach we have no method to control image aspect ratio or pixel dimensions.

We will manage display size with CSS, and recommend a light box overlay instead of the mockup’s accordion, to ensure maximum compatibility with various screen sizes and image aspect ratios.

Pixel dimensions we’ll just have to live with for now. Which should be fine given small sample

[jeffreyameyer]

Ugh, really? No scaling, etc.?

What would the lightbox overlay look like?

On Tue, Oct 1, 2019 at 11:21 AM Dan Rademacher notifications@github.com wrote:

related to having an unknown number of images as shown in OpenHistoricalMap/issues#758 https://github.com/OpenHistoricalMap/issues/issues/758, noting that with fully client side approach we have no method to control image aspect ratio or pixel dimensions.

We will manage display size with CSS, and recommend a light box overlay instead of the mockup’s accordion, to ensure maximum compatibility with various screen sizes and image aspect ratios.

Pixel dimensions we’ll just have to live with for now. Which should be fine given small sample

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/issues/issues/755?email_source=notifications&email_token=AALM4EVZJ567J2KET545STDQMOIKLA5CNFSM4I4NDHXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HO5U2WA, or mute the thread https://github.com/notifications/unsubscribe-auth/AALM4EQDLGY26QAS7NXA24LQMOIKLANCNFSM4I4NDHXA .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

[danrademacher]

Well we can display the image at whatever size we want but by definition a client side application can not downsample high res images and write them to disk somewhere. That implies a full stack app somewhere with access to a file system, or maybe a service that writes to S3.

We can show a sample light box when we get there. Plenty of options on styling that

[jeffreyameyer]

Ah, I thought you could just ask a browser to fit an image into a prescribed area using html - we might take a network hit for large images, but that's what fiber is for, right?

On Tue, Oct 1, 2019 at 12:13 PM Dan Rademacher notifications@github.com wrote:

Well we can display the image at whatever size we want but by definition a client side application can downsample high res images and write them to disk somewhere. That implies a full stack app somewhere with access to a file system, or maybe a service that writes to S3.

We can show a sample light box when we get there. Plenty of options on styling that

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/issues/issues/755?email_source=notifications&email_token=AALM4ETEUKNVOUJPTSAE37LQMOOMRA5CNFSM4I4NDHXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEACNA3I#issuecomment-537186413, or mute the thread https://github.com/notifications/unsubscribe-auth/AALM4EUHGGWAXVSHM5GS3QTQMOOMRANCNFSM4I4NDHXA .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

[gregallensworth]

See updates to OpenHistoricalMap/issues#758 in which the slideshow was implemented under the larger umbrella of "full content" There are newer ways to handle image scaling and cropping scenarios, which are much better than those old techniques.