Basic full content display

[danrademacher]

Here's an example of what we want to end up with:

Sample content is all present here: https://www.openhistoricalmap.org/api/0.6/way/198099635

If we have loose ends, such as how followed by is defined, let's stub them out and spin those into new issues.

Live version with image credit and a new image of a map, not sure how that works, is Slide 3 here: https://docs.google.com/presentation/d/1UnyeglP1q_ef_i1gtvK6czzhuVLhdALdA3PGMXFrl_w

[danrademacher]

@jeffreyameyer can you remind me whether we had a plan for image credits here?

[jeffreyameyer]

That's a key missing item. I've added it to the mockups.

[image: image.png]

On Mon, Sep 30, 2019 at 4:02 PM Dan Rademacher notifications@github.com wrote:

@jeffreyameyer https://github.com/jeffreyameyer can you remind me whether we had a plan for image credits here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/issues/issues/758?email_source=notifications&email_token=AALM4ETKNIK7WGABHW7SIB3QMKAPVA5CNFSM4I37NOOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD77LQHA#issuecomment-536786972, or mute the thread https://github.com/notifications/unsubscribe-auth/AALM4EWL3MWJOTB6YH6XYILQMKAPVANCNFSM4I37NOOA .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

[danrademacher]

@jeffreymeyer can you also add tag and value to the two sample end points if you haven’t already? That way we can feed in actual data from XML endpoint

[jeffreyameyer]

In this case:

img:<#>:caption: img:<#>:src_text:

and the link is to the url in: img:<#>:

Someone may come back & want us to link more explicit copyright notation, but let's do just this for now...

On Tue, Oct 1, 2019 at 11:01 AM Dan Rademacher notifications@github.com wrote:

@JeffreyMeyer https://github.com/JeffreyMeyer can you also add tag and value to the two sample end points if you haven’t already? That way we can feed in actual data from XML endpoint

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/issues/issues/758?email_source=notifications&email_token=AALM4ETNAE5GIZPTIXLPBQDQMOF7RA5CNFSM4I37NOOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEACFYMQ#issuecomment-537156658, or mute the thread https://github.com/notifications/unsubscribe-auth/AALM4EQWVZG76ZO6AYTLIOTQMOF7RANCNFSM4I37NOOA .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

[gregallensworth]

Some examples of work so far:

https://openhistoricalmap.github.io/ohm-inspector/?osmtype=way&osmid=198099635

https://openhistoricalmap.github.io/ohm-inspector/?osmtype=way&osmid=198287637

Notes:

• This inserts itself into the DOM in the OSM/OHM sidebar. This demo is not a OSM/OHM web page, so of course the sidebar does not look the same, nor does the Classic Inspector view which would show the in-page sidebar already present. I will see about coming up with some code which could be pasted into the debugger while viewing the OHM website, in order to inject the script and effect this in the proper context.

• Some data are still pending e.g. these two which have photos do not have caption nor src_text for any photo. The code supports those, and they Should Just Work (and then perhaps a style pass) once captions and attributions are filled in.

[jeffreyameyer]

Love what I see so far.

Quick question - is it possible to grab an initial set of text (some fixed number of words/letters from the wikipedia entry for each item & put that as a little bit of background text. Like the mockups or (I know, I know...) how Google does it:

[danrademacher]

@jeffreyameyer any idea from where Google is pulling that? If there's a Wikipedia API endpoint or OpenGraph element, we could pull that as-is. But it is also possible that Google is processing the content with fancy processing to make a pithy summary. Is the text in your mock modified at all from Wikipedia? We couldn't find that exact string anywhere obvious.

[danrademacher]

Ignore my previous content -- see OpenHistoricalMap/issues#756