Improve handling of settings.yml for website, staging, production

[danrademacher]

Note on ENV vars and settings.yml

• For public things that don’t change by env, those currently come from
  https://github.com/OpenHistoricalMap/ohm-deploy/blob/main/images/web/config/settings.yml, but we want to change this so ohm-deploy reads directly from this file: https://github.com/OpenHistoricalMap/ohm-website/blob/staging/config/settings.yml

• For anything secret or ENV dependent, we use env vars and change the start.sh script https://github.com/OpenHistoricalMap/ohm-deploy/blob/main/images/web/start.sh

We should change to the following:

1. ohm-deploy should read directly from https://github.com/OpenHistoricalMap/ohm-website/blob/staging/config/settings.yml
2. a new settings-local.yml file exists in ohm-deploy that includes ONLY the variables we need to override because they are secret (so not tracked in git) or they vary by environment.
3. start.sh in ohm-deploy references that settings-local.yml with sed commands

@batpad can you confirm this aligns with your recommendation during the call?

[Rub21]

This changes has been deploy in staging https://github.com/OpenHistoricalMap/ohm-deploy/pull/292

[Rub21]

Actually this is settings.local.yml not settings-local.yml , also some values are not overwritten that is causing, https://github.com/OpenHistoricalMap/issues/issues/779

[danrademacher]

Is the work on this ticket complete on staging? I think so, but want to be sure -- if so, once we do our next prod deploy, we can close this ticket