Tiles containing route relations are malformed

[Rub21]

From Discord. https://discord.com/channels/413070382636072960/634106496560398349/1230095958969421875

The user is reporting that the tiles are taking time. When I take a look, I notice that the tiles are not appearing because a date is wrong.

Overpass Link

[Rub21]

I fixed the wrong date, and the tiles is appearing https://www.openhistoricalmap.org/relation/2789850/history#map=13/51.0217/3.7612&layers=O&date=1924-04-17&daterange=1824-01-01,2024-12-31

[Rub21]

This is weird. I have been checking relations that had incorrect dates, but those are now showing correctly. However, the error occurs when a relation or way displays the format of the date correctly but not the number. For example, 1906-09-31 https://www.openhistoricalmap.org/relation/2796047#map=13/50.6578/3.7684&layers=ON&date=1924-04-17&daterange=1824-01-01,2024-12-31

After fixing the wrong date, it works correctly :

[Rub21]

In conclusion, it seems that the tiler works well even if the dates are in incorrect formats or wrong for nodes and ways. However, in the case of relations, if they have a bad date format, they do not show. I believe this is related to the newly added layer, transport_lines_relations If it seems we are still not using it in the styles, maybe we can remove it.

@vknoppkewetzel Are you suing the transport_lines_relations on the map styles?

cc. @danrademacher

[Rub21]

Also, I wrote a script that will help us detect wrong dates in nodes, ways, and relations using the Planet PBF file. https://github.com/OpenHistoricalMap/ohm-dates-analyzer/

• relation.csv.zip
• ways.csv.zip
• node.csv.zip

[vknoppkewetzel]

Hey @Rub21 transport_lines_relations is only in the draft demo style (tegola-ohm-draft) and not in production yet, mostly because I need clarity/confirmation on expectations on how I should style it.

[1ec5]

However, in the case of relations, if they have a bad date format, they do not show.

I get numerous Decoding failed errors in the console when attempting to view https://www.openhistoricalmap.org/relation/2796047, even with your fix. I also get the same errors attempting to view https://www.openhistoricalmap.org/relation/2695155 or https://www.openhistoricalmap.org/relation/2749954, in which the start_date and end_date are both syntactically and calendrically valid. In fact, I can only view tiles that contain route relations without start_date or end_date, such as https://www.openhistoricalmap.org/relation/2738230.

I wonder if the culprit is that these queries reference an ambiguous tags rather than r.tags:

https://github.com/OpenHistoricalMap/ohm-deploy/blob/9de4aecf8c78469c3015a8aaecc658dee008cc96/images/tiler-server/config/providers/transport_lines_relation.toml#L19-L20 https://github.com/OpenHistoricalMap/ohm-deploy/blob/9de4aecf8c78469c3015a8aaecc658dee008cc96/images/tiler-server/config/providers/transport_lines_relation.toml#L51-L52

I’m not too well-versed in PostgresQL, so this might be a red herring. But definitely something is up with the date tags specifically.

[Rub21]

@1ec5 @vknoppkewetzel Due to the fact that we are not using the transport_lines_relation, I have disabled it for now. I will further investigate the issue in the SQL queries and deploy it later.

[1ec5]

Should we close this issue, since the problematic code has been backed out?